Conversation
zbarsky-openai
approved these changes
Jan 9, 2026
| # Install Bazel via Bazelisk (mirrors bazelbuild/setup-bazelisk@v3). | ||
| ARG BAZELISK_VERSION=latest | ||
| RUN arch="$(uname -m)" && \ | ||
| case "$arch" in \ |
Contributor
There was a problem hiding this comment.
not a huge deal but you can probably simplify this to assume your arch is always a supported one and always use latest, or just pin whatever is currently the latest if you want reproducibility
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In working on the new
Dockerfile.bazelin #8875, it occurred to me these would be good fixes to make for the devcontainer.