Fix typing in ReadableSpan#3528
Merged
ocelotl merged 10 commits intoopen-telemetry:mainfrom Nov 16, 2023
Merged
Conversation
Contributor
Author
|
There's a lot more of this work that needs to be done across all of the repo(s). Is there any appetite for this from the maintainer team? |
Contributor
Author
|
Also I'd skip this from the changelog if possible since it's (mostly) an internal refactor |
Member
|
Only the |
Member
|
+1 to that, I'd love to have typing working on the SDK. This is tracked in #1608 |
aabmass
approved these changes
Nov 15, 2023
Member
aabmass
left a comment
There was a problem hiding this comment.
One nit on the PR title, seems like we're simplifying some things as well not just updating the type annotations
adriangb
commented
Nov 15, 2023
Contributor
Author
|
@srikanthccv this is ready for review |
srikanthccv
approved these changes
Nov 16, 2023
Contributor
Author
|
Thanks folks! |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes some incorrect typing in ReadableSpan, including assumptions about the type of
attributeswhich causes a bug when they're not aBoundedAttributesinstance.How Has This Been Tested?
This is a refactor so I'm relying on the existing tests
Does This PR Require a Contrib Repo Change?
Checklist: