Conversation
This was referenced Dec 15, 2024
larskanis
force-pushed
the
arm64
branch
5 times, most recently
from
d4f047f to
0bccfc0
Compare
This allows to add a customized manifest within the installer build process later on. The Microsoft mt.exe allows to add a manifest to a EXE or DLL file after the build. But there is no such tool in gcc/llvm. So adding a placeholder manifest allows to later change the XML with simple text replacement. That way the ruby build doesn't need any patches and is not bound too much to the installer. The exe manifest of ruby core is re-enbaled now, since DLL manifests are sufficient to declare DLL dependencies. Also use a build directory like the MSYS2/MINGW-packages.
larskanis
changed the title
larskanis
added a commit
that referenced
this pull request
Jan 9, 2025
larskanis
added a commit
that referenced
this pull request
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a placeholder manifest to
exeanddllfiles, since there is no default manifest when linked with clang.