Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

fix: EEXIT error raised by sfdx-cli results in err instanceof ExitError equals false#157

Merged
amphro merged 1 commit intooclif:masterfrom
jayree:sfdx-cli-EEXIT-patch
May 12, 2021
Merged

fix: EEXIT error raised by sfdx-cli results in err instanceof ExitError equals false#157
amphro merged 1 commit intooclif:masterfrom
jayree:sfdx-cli-EEXIT-patch

Conversation

@jayree
Copy link
Contributor

@jayree jayree commented May 9, 2021

@jayree jayree force-pushed the sfdx-cli-EEXIT-patch branch from a5cbb33 to c606f3e Compare May 9, 2021 17:27
Copy link
Contributor

@amphro amphro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a safe change. I don't like throwing ExitErrors on successful commands... but that is a larger problem. I'll approve.

@kamal
Copy link

kamal commented Jul 7, 2021

@amphro would it be possible to cut a release of oclif/errors that contains this fix?

@amphro
Copy link
Contributor

amphro commented Jul 7, 2021

Published 1.3.5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

For custom commands help exits with Error: EEXIT: 0

3 participants