Merged
Conversation
Add support for CLICKHOUSE_URL (for full connection string), CLICKHOUSE_USERNAME (fallback for CLICKHOUSE_USER), and CLICKHOUSE_DB (fallback for CLICKHOUSE_DATABASE). This enables Doppler integration without requiring bash wrappers to translate between env var names. Exported parseClickHouseUrl and resolveConnectionConfig for testability. Added 15 tests covering URL parsing and env var precedence. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLICKHOUSE_URL(parsed into host, port, secure, and password)CLICKHOUSE_USERNAMEas fallback forCLICKHOUSE_USERCLICKHOUSE_DBas fallback forCLICKHOUSE_DATABASEThis enables seamless Doppler integration without requiring bash wrappers to translate between env var names.
Changes
resolveConnectionConfig()andparseClickHouseUrl()as exported functions for testability🤖 Generated with Claude Code