Conversation
- Add build script (bun build --compile) producing dist/chcli binary - Add e2e test suite that builds then runs 8 tests against the compiled binary with a real ClickHouse connection - Add test:env script wrapping tests with doppler for local dev - Expose CLICKHOUSE_* secrets in CI workflow - Document that tests requiring env vars must fail, never skip Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use || instead of ?? for env var defaults so empty strings (from missing GitHub secrets) fall through to defaults. Remove CLICKHOUSE_USER from CI env since it's not in doppler. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun build --compilestep producing a standalonedist/chclibinary--timeflag, SHOW DATABASES, system.numbers)test:envscript wrapping tests withdoppler runfor local devCLICKHOUSE_*secrets in CI workflow (synced from dopplerchcli/ciconfig)Test plan
bun run test:envpasses locally (25 tests: 17 unit + 8 e2e)🤖 Generated with Claude Code