fix: handle missing attributes when using select param #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add infer_missing=True to ListResponse.from_dict to handle missing attributes - Add test case to verify select parameter behavior - Fixes #395 Co-Authored-By: Aaron de Mello <[email protected]>
Contributor
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
Add "(aside)" to your comment to have me ignore it. |
AaronDDM
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix KeyError when using select parameter with threads/messages API.
When using the select parameter to request specific fields, the API would throw a KeyError for missing attributes that weren't requested. This fix adds infer_missing=True to handle missing attributes gracefully.
Fixes #395
Link to Devin run: https://app.devin.ai/sessions/c7f701d535544b338abf03ec960537dc