Validate attachment response and throw error #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraju3
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
AaronDDM
reviewed
Dec 9, 2024
AaronDDM
reviewed
Dec 9, 2024
Co-authored-by: Aaron de Mello <[email protected]>
kraju3
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
kraju3
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
kraju3
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
Contributor
Author
|
@AaronDDM Is it good to merge this PR? |
AaronDDM
approved these changes
Dec 16, 2024
kraju3
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
AaronDDM
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
kraju3
force-pushed
the
fix-attachment-download
branch
from
28d16cf to
0941036
Compare
kraju3
had a problem deploying
to
sdk-reference
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment we are not returning a NylasAPIError exception if we are unable to download the attachment. Which results in customers writing the content to a file. This PR adds a validation for the download request and return an exception if the status code is >=400.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.