Trying to fix the parsing of .tex and .txt file extensions when parsing templates#55
Open
Chifiwang wants to merge 43 commits intonvimdev:mainfrom
Open
Trying to fix the parsing of .tex and .txt file extensions when parsing templates#55Chifiwang wants to merge 43 commits intonvimdev:mainfrom
Chifiwang wants to merge 43 commits intonvimdev:mainfrom
Conversation
Author
|
I noticed that when pasting multiple versions of the template into one file there was a nil exception so I added a guarding if statement to mitigate that. It looks as though the output is correct none the less |
Member
|
thanks I think we need a test here |
Author
|
No problem! |
added 20 commits
December 20, 2024 01:04
added 18 commits
December 20, 2024 03:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to create a template for some latex and noticed that it wouldn't parse. The other option of .tpl removed my lsp and syntax highlighting, so I wanted to see why it wouldn't parse
From what I saw, within the function
temp.get_temp.list()the call tovim.filetype.match({ filename = name })will not match .tex and .txt file extensions by design (see https://www.reddit.com/r/neovim/comments/1cb4kty/vimfiletypematch_returns_nil/) for why.Because of this, templates in latex .tex, and also incidentally .txt files, will not parse requiring you to use .tpl files with a header comment of
;; texto be read properly.To fix this I reimplemented the functionality of
vim.filetype.matchand adjusted the code according to the new function's api.If you have time feel free to review and adjust the code as needed or contact me if I made a mistake in understanding when adjusting the code.
Thank you for your time.