Skip to content

fix: exclude list being overwritten #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glepnir merged 1 commit into from
Jun 1, 2024
Merged

fix: exclude list being overwritten #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions lua/indentmini/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,8 @@ end
return {
setup = function(conf)
conf = conf or {}
opt.exclude = vim.tbl_extend(
'force',
{ 'dashboard', 'lazy', 'help', 'markdown', 'nofile', 'terminal', 'prompt' },
conf.exclude or {}
)
opt.exclude = { 'dashboard', 'lazy', 'help', 'markdown', 'nofile', 'terminal', 'prompt' }
vim.list_extend(opt.exclude, conf.exclude or {})
Copy link
Member

@glepnir glepnir Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
vim.list_extend(opt.exclude, conf.exclude or {})
vim.list_extend({ 'dashboard', 'lazy', 'help', 'markdown', 'nofile', 'terminal', 'prompt' }, conf.exclude or {})

Copy link
Member

@glepnir glepnir Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be inline.

Copy link
Contributor Author

@AyushRawal AyushRawal Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vim.list_extend mutates the first list and does not return the merged list

Copy link
Member

@glepnir glepnir Jun 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha sry I forge it :)

opt.config.virt_text = { { conf.char or '│' } }
set_provider(ns, { on_win = on_win, on_line = on_line })
end,
Expand Down