Skip to content

base-16: nvim-tree: fix GitDirty circular link, update GitNew to match gitsigns#181

Merged
echasnovski merged 2 commits intonvim-mini:base16_nvim-treefrom
alex-courtis:nvim-tree-git-dirty-circular
Dec 25, 2022
Merged

base-16: nvim-tree: fix GitDirty circular link, update GitNew to match gitsigns#181
echasnovski merged 2 commits intonvim-mini:base16_nvim-treefrom
alex-courtis:nvim-tree-git-dirty-circular

Conversation

@alex-courtis
Copy link
Contributor

@alex-courtis alex-courtis commented Dec 25, 2022

Hello from nvim-tree

NvimTreeGitDirty was linking to itself. Used 0E as per gitsigns.

Updated NvimTreeGitNew from 0D to 0A as per neo-tree for better legibility.

@echasnovski echasnovski changed the base branch from main to base16_nvim-tree December 25, 2022 08:02
@echasnovski
Copy link
Member

Thanks! I didn't think linking to itself is even possible... I think it was meant to be linked to NvimTreeGitDeleted as per 'nvim-tree' default colors. But I like your second reasoning more: making it more aligned with 'neo-tree' seems like a better choice. In 'nvim-tree' NvimTreeGitDirty is used for unstaged files, so will make it aligned with NeoTreeGitUnstaged, i.e. base08 (which also the same for NvimTreeGitDeleted).

Change of NvimTreeGitNew to base0A is also good.

I'll merge in separate branch and make joint commit. Thanks for PR!

@echasnovski echasnovski merged commit 5d5dec6 into nvim-mini:base16_nvim-tree Dec 25, 2022
@echasnovski
Copy link
Member

It is in main now.

@alex-courtis
Copy link
Contributor Author

I'll merge in separate branch and make joint commit.

Thank you. I'll be back when we finish modified buffer indication.

Thanks! I didn't think linking to itself is even possible...

It seems like it falls back to Normal when you do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants