Conversation
|
API migration require('Comment.api').{toggle => toggle_current_linewise}()
require('Comment.api').{comment => comment_current_linewise}()
require('Comment.api').{uncomment => uncomment_current_linewise}()
require('Comment.api').{gcc => toggle_current_linewise_op}()
require('Comment.api').{gbc => toggle_current_blockwise_op}()
require('Comment.api').{gc => toggle_linewise_op}()
require('Comment.api').{gb => toggle_blockwise_op}()
require('Comment.api').{gco => insert_linewise_below}()
require('Comment.api').{gcO => insert_linewise_above}()
require('Comment.api').{gcA => insert_linewise_eol}() |
|
Looks good, especially since it seems to remove duplicate API? Only suggestion would be to drop the |
Quite the opposite ;)
I have three variant such as toggleln_linewise() -- current line but no dot-repeat
toggleln_linewise_op() -- current line + dot-repeat
toggle_linewise_op() -- multiple line + dot-repeatIf I remove toggle_linewise() -- current line but no dot-repeat
toggle_linewise_op() -- multiple line + dot-repeat |
|
Oh, I see. I thought the list above was complete. May I then suggest |
Ahh, yes. I can change that. Thanks! (those names are getting longer haha) |
Indeed, but that's the whole point of an API -- you're not supposed to type them out every time but bind them (or use them in a plugin) where length is less important than readability without checking the docs. ;) |
|
@clason I've changed |
Closes #78
This time it's in a good shape.