fix(ft/fennel): fix double semicolon commentstring#304
Merged
numToStr merged 1 commit intonumToStr:masterfrom Feb 16, 2023
atchim:fix-fennel-commentstring
Merged
fix(ft/fennel): fix double semicolon commentstring#304numToStr merged 1 commit intonumToStr:masterfrom atchim:fix-fennel-commentstring
numToStr merged 1 commit intonumToStr:masterfrom
atchim:fix-fennel-commentstring
Conversation
Owner
|
Just curious, Is this a syntax error? Because even in the home page they are using double semicolon for comments. |
atchim
changed the title
Contributor
Author
|
It is not a syntax error, but despite the official Fennel home page, the common practice is to use only 1 semicolon. Also, the verbose set commentstring
" commentstring=;%s
" Last set from /usr/share/nvim/runtime/ftplugin/fennel.vim line 11I was mistakenly referring to semicolon as "comma", sorry. |
Owner
|
Fair enough! I don't have a strong opinion as I don't write fennel myself, so this is good to me :) |
numToStr
approved these changes
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the double semicolons used to comment Fennel files.