Skip to content

Add null mining sound#44

Merged
nucleartide merged 5 commits intomasterfrom
jason/add-null-mining-sound
Apr 6, 2023
Merged

Add null mining sound#44
nucleartide merged 5 commits intomasterfrom
jason/add-null-mining-sound

Conversation

@nucleartide
Copy link
Copy Markdown
Owner

@nucleartide nucleartide commented Apr 6, 2023

Workflow

  1. Update readme with pull request link so that the diff enables opening a pull request.
  2. Find a sound effect from freesound.org.
  3. Check the sound's license to ensure that I can use it.
  4. Import sound into Sounds/ folder.
  5. Update Sounds/Attribution.md doc.
  6. Expose new reference in the AllTheSounds ScriptableObject, and hook up the AudioClip. Alternatively, if you want to play the sound as its own AudioSource, then create the AudioSource and hook up the AudioClip.
  7. Add test methods to SoundManager (or a separate script) that play the sound. If the audio clip is split into many sections, identify sections within the audio clip to play with the AudioClipSection class, then use AudioSourceHelpers.PlaySoundInterval.
  8. Expose game event for when you want the sound to be played. For example, the PlayerAnimationEvents script exposes player animation events to C#. You may need to also impose certain conditions for playing the sound.
  9. Make SoundManager (or your separate script) listen to the new game event, and call the corresponding play-sound method when the event occurs.

@nucleartide nucleartide marked this pull request as ready for review April 6, 2023 19:11
@nucleartide nucleartide merged commit 72b171f into master Apr 6, 2023
@nucleartide nucleartide deleted the jason/add-null-mining-sound branch April 6, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant