Refactor to get rid of CharacterController#28
Merged
nucleartide merged 3 commits intomasterfrom Mar 1, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
Changelog
GameInputCharacterControllerfromPlayerControllerclass, and simplify logicHow it works
I've seen on YouTube videos that avoiding Unity Physics and CharacterControllers is best if one wants to add multiplayer support to their game later on.
So this pull request gets rid of the CharacterController that is currently part of the
PlayerGameObject. Nothing changes from a player point of view, but the internal logic is far simpler.Quality Assurance
You can indeed still walk, run around, and rotate the camera: