Skip to content

Refactor to get rid of CharacterController#28

Merged
nucleartide merged 3 commits intomasterfrom
jason/get-rid-of-character-controller
Mar 1, 2023
Merged

Refactor to get rid of CharacterController#28
nucleartide merged 3 commits intomasterfrom
jason/get-rid-of-character-controller

Conversation

@nucleartide
Copy link
Copy Markdown
Owner

@nucleartide nucleartide commented Mar 1, 2023

JIRA Ticket

Sorry folks, this is internal to my Notion workspace!

https://www.notion.so/nucleartide/Extract-CharacterController-92f60493d53346b3962c5abe5fbb5169?pvs=4

Changelog

Provide a bulleted list of changes that were made in this pull request.

  • Consolidate input logic in GameInput
  • Remove CharacterController from PlayerController class, and simplify logic
  • Fix build settings so that correct scene is included in build

How it works

Explain what you did, how you did it, and why you did it. Also any lessons that might be useful to others.

(Note to self: it's easiest to do a stream-of-consciousness writeup of what you did.)

I've seen on YouTube videos that avoiding Unity Physics and CharacterControllers is best if one wants to add multiplayer support to their game later on.

So this pull request gets rid of the CharacterController that is currently part of the Player GameObject. Nothing changes from a player point of view, but the internal logic is far simpler.

Quality Assurance

Take some screenshots as confirmation of quality assurance.

You can indeed still walk, run around, and rotate the camera:

Screenshot 2023-03-01 at 3 03 27 PM

@nucleartide nucleartide marked this pull request as ready for review March 1, 2023 20:04
@nucleartide nucleartide merged commit 9ae5c20 into master Mar 1, 2023
@nucleartide nucleartide deleted the jason/get-rid-of-character-controller branch March 1, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant