Skip to content

feat(i18n): update German translation#1680

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
trueberryless:i18n/de
Feb 26, 2026
Merged

feat(i18n): update German translation#1680
danielroe merged 1 commit intonpmx-dev:mainfrom
trueberryless:i18n/de

Conversation

@trueberryless
Copy link
Contributor

Description

Update German translations and add new, previously missing translation keys.

@vercel
Copy link

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 26, 2026 10:25pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 26, 2026 10:25pm
npmx-lunaria Ignored Ignored Feb 26, 2026 10:25pm

Request Review

@github-actions
Copy link

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/de-DE.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

📝 Walkthrough

Walkthrough

This pull request modifies the German translation file (i18n/locales/de-DE.json) with text refinements and structural additions. It updates various translation strings including SEO descriptions, taglines, cookie-related terminology, and vanity download hints. The PR introduces new public translation blocks for sponsors and open-source partners sections, and adds copy_alt metadata blocks to provide alternative textual descriptions for UI elements like pause animation controls and version matching messages. The changes consist of 36 lines added and 12 removed.

Possibly related PRs

  • PR 1605: Modifies German translations for trend animation localisation, specifically touching pause_animation copy_alt metadata similar to this PR.
  • PR 1477: Adds new top-level and about-level public translation keys to the German locale file, comparable to the sponsors and oss_partners additions in this PR.
  • PR 972: Introduces the package.replacement translation block that this PR extends with copy_alt metadata.

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset, which updates German translations and adds new translation keys to i18n locale files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
lunaria/files/de-DE.json (1)

381-395: Minor: Consider grammatical handling of {granularity}en suffix.

The general_description on line 394 uses {granularity}en to form German adjectives (e.g., "wöchentlichen"). This works for the defined granularity values ("Täglich" → "täglichen", "Wöchentlich" → "wöchentlichen", etc.), but relies on the granularity strings being provided in a compatible form.

If granularity values are passed as lowercase adjective stems (e.g., "täglich", "wöchentlich"), appending "en" produces correct dative forms. Verify that the application provides granularity values in the expected format for this concatenation to work correctly in German grammar.


ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d5bb56 and 53e7cc1.

📒 Files selected for processing (2)
  • i18n/locales/de-DE.json
  • lunaria/files/de-DE.json

@danielroe danielroe added this pull request to the merge queue Feb 26, 2026
Merged via the queue into npmx-dev:main with commit 5bcfb8e Feb 26, 2026
17 checks passed
@trueberryless trueberryless deleted the i18n/de branch February 26, 2026 22:55
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants