feat: show a warning when significant size increase by 43081j · Pull Request #1673 · npmx-dev/npmx.dev

43081j · 2026-02-26T15:39:24Z

When viewing a package, this shows a warning box making the user aware
that the number of dependencies or the install size significantly
increased.

It sets the thresholds as:

Significant size increase = 25%
Significant dependency count increase = >5

🔗 Linked issue

N/A

When viewing a package, this shows a warning box making the user aware that the number of dependencies or the install size significantly increased. It sets the thresholds as: - Significant size increase = 25% - Significant dependency count increase = >5

vercel · 2026-02-26T15:39:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ready	Preview, Comment	Feb 26, 2026 10:20pm
npmx.dev	Ready	Preview, Comment	Feb 26, 2026 10:20pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
npmx-lunaria	Ignored		Feb 26, 2026 10:20pm

github-actions · 2026-02-26T15:40:11Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
lunaria/files/en-GB.json	Localization changed, will be marked as complete. 🔄️
lunaria/files/en-US.json	Source changed, localizations will be marked as outdated.

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

codecov · 2026-02-26T15:40:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

coderabbitai · 2026-02-26T15:45:24Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds a new Vue 3 component SizeIncrease to display install-size and dependency-count diffs; introduces the useInstallSizeDiff composable that chooses a comparison version, lazily fetches prior install-size data, computes an InstallSizeDiff and exposes diff, comparisonVersion and comparisonStatus; adds shared install-size types and re-exports them; removes duplicate interfaces from server utils; integrates the composable and component into the package page; adds i18n keys and schema entries for size increase messages; and adds unit and a11y tests for the composable and component.

Possibly related PRs

feat(i18n): format numbers with Intl.NumberFormat #1149 — introduces useBytesFormatter and useNumberFormatter used by the new SizeIncrease component.
fix: show correct install size for native packages #1357 — modifies package install-size / dependency rendering and overlaps with the install-size composable/component changes.

Suggested labels

front, a11y

Suggested reviewers

danielroe
alexdln

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description check	✅ Passed	The pull request description clearly describes the feature being added: a warning box showing when install size or dependency count significantly increased, with defined thresholds.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch jg/we-have-to-go-bigger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 5

🧹 Nitpick comments (1)

test/nuxt/composables/use-install-size-diff.spec.ts (1)

99-194: Add explicit boundary tests for threshold cut-offs.

Please add exact-boundary assertions for 25% size increase and +5 dependencies to lock in the intended > semantics.

🧪 Suggested test additions

+    it('does not exceed size threshold at exactly 25%', async () => {
+      const pkg = createPackage({ '1.0.0': '2020-01-01', '1.1.0': '2021-01-01' })
+      const current = createInstallSize({ version: '1.1.0', totalSize: 6250, dependencyCount: 3 })
+      fetchSpy.mockResolvedValue(
+        createInstallSize({ version: '1.0.0', totalSize: 5000, dependencyCount: 3 }),
+      )
+
+      const { diff } = useInstallSizeDiff('pkg-size-boundary', '1.1.0', pkg, current)
+      await vi.waitFor(() => expect(fetchSpy).toHaveBeenCalled())
+      expect(diff.value).toBeNull()
+    })
+
+    it('does not exceed dependency threshold at exactly +5 dependencies', async () => {
+      const pkg = createPackage({ '1.0.0': '2020-01-01', '1.1.0': '2021-01-01' })
+      const current = createInstallSize({ version: '1.1.0', totalSize: 5000, dependencyCount: 8 })
+      fetchSpy.mockResolvedValue(
+        createInstallSize({ version: '1.0.0', totalSize: 5000, dependencyCount: 3 }),
+      )
+
+      const { diff } = useInstallSizeDiff('pkg-dep-boundary', '1.1.0', pkg, current)
+      await vi.waitFor(() => expect(fetchSpy).toHaveBeenCalled())
+      expect(diff.value).toBeNull()
+    })

As per coding guidelines "**/*.{test,spec}.{ts,tsx}: Write unit tests for core functionality using vitest."

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf4b537 and e7e612d.

📒 Files selected for processing (11)

app/components/Package/SizeIncrease.vue
app/composables/useInstallSizeDiff.ts
app/pages/package/[[org]]/[name].vue
i18n/locales/en.json
i18n/schema.json
lunaria/files/en-GB.json
lunaria/files/en-US.json
server/utils/install-size.ts
shared/types/index.ts
shared/types/install-size.ts
test/nuxt/composables/use-install-size-diff.spec.ts

💤 Files with no reviewable changes (1)

server/utils/install-size.ts

app/composables/useInstallSizeDiff.ts

i18n/locales/en.json

lunaria/files/en-GB.json

lunaria/files/en-US.json

trueberryless · 2026-02-26T19:40:52Z

Awesome, love this feature. Do you have a link to an example package where this can be seen in action?

danielroe · 2026-02-26T21:48:08Z

I suspect https://npmx-a1vxjhmu7-npmx.vercel.app/package/resolve/v/2.0.0-next.6 ...

trueberryless

LGTM 🎉

Awesome new test cases as well, thank you!

vercel bot deployed to Preview – npmx.dev February 26, 2026 15:41 View deployment

coderabbitai bot reviewed Feb 26, 2026

View reviewed changes

app/composables/useInstallSizeDiff.ts Show resolved Hide resolved

app/composables/useInstallSizeDiff.ts Show resolved Hide resolved

i18n/locales/en.json Show resolved Hide resolved

lunaria/files/en-GB.json Show resolved Hide resolved

lunaria/files/en-US.json Show resolved Hide resolved

43081j added 2 commits February 26, 2026 15:54

test: add a11y test

219fe62

chore: fix spelling

39e1194

vercel bot deployed to Preview – npmx.dev February 26, 2026 16:00 View deployment

chore: race condition fun

8f0c28f

vercel bot deployed to Preview – npmx.dev February 26, 2026 16:04 View deployment

chore: fix em up

96f43bb

vercel bot deployed to Preview – npmx.dev February 26, 2026 16:13 View deployment

fix: validate current install size staleness during navigation

70486ca

vercel bot deployed to Preview – npmx.dev February 26, 2026 22:17 View deployment

Merge branch 'main' into jg/we-have-to-go-bigger

0e3f107

danielroe approved these changes Feb 26, 2026

View reviewed changes

vercel bot deployed to Preview – docs.npmx.dev February 26, 2026 22:20 View deployment

vercel bot deployed to Preview – npmx.dev February 26, 2026 22:20 View deployment

trueberryless approved these changes Feb 26, 2026

View reviewed changes

danielroe added this pull request to the merge queue Feb 26, 2026

Merged via the queue into main with commit a38a2f7 Feb 26, 2026
20 checks passed

danielroe deleted the jg/we-have-to-go-bigger branch February 26, 2026 22:34

Uh oh!

Conversation

43081j commented Feb 26, 2026

🔗 Linked issue

Uh oh!

vercel bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

codecov bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trueberryless commented Feb 26, 2026

Uh oh!

danielroe commented Feb 26, 2026

Uh oh!

trueberryless left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Feb 26, 2026 •

edited

Loading

codecov bot commented Feb 26, 2026 •

edited

Loading

coderabbitai bot commented Feb 26, 2026 •

edited

Loading