fix(a11y): use semantic html for keyword list#1401
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThis pull request converts the keywords container in app/components/Package/Card.vue from a Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
4e9bc1c to
f8267f2
Compare
For Safari + VoiceOver
The
aria-labelis invalid on a<div>element. I seized the opportunity and used semantic html (ul + li) to describe the keyword list better, which also permits thearia-labelattribute.