chore: add proper types to OgImage Package.d.vue.ts workaround#1217
chore: add proper types to OgImage Package.d.vue.ts workaround#1217
Package.d.vue.ts workaround#1217Conversation
It appears this file was here to break a circular type resolution. `nuxt-og-image` generates a type declaration that imports `Package.vue type`, which needs auto-import globals from `nuxt.d.ts`, which needs the `nuxt-og-image` type declaration, creating a cycle. The old file used `any` which was a band-aid. I couldn't come up with a way to remove this file entirely, but this at least types the component props so consumers still get real type-checking.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe default export type in a Vue component type declaration file has been replaced with an explicit 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
43081j
left a comment
There was a problem hiding this comment.
too bad we have to do this, would be good to somehow solve it one day such that we can drop the workaround
however, looks good to me
|
this will be resolved in the next version of |
It appears this file was here to break a circular type resolution.
nuxt-og-imagegenerates a type declaration that importsPackage.vue type, which needs auto-import globals fromnuxt.d.ts, which needs thenuxt-og-imagetype declaration, creating a cycle.The old file used
anywhich was a band-aid. I couldn't come up with a way to remove this file entirely, but this at least types the component props so consumers still get real type-checking.