fix(config): user-agent properly shows ci

[wraithgar]

The way we were flattening user-agent back into itself meant that any
values that were dependent on other config items would never be seen,
since we have to re-flatten the item for each one it depends on.

We also weren't re-flattening the user-agent when setting workspaces or
workspace, which were things that affected the final result.

This does change the main config value of user-agent but not the
flattened one. We are not using the main config value anywhere (which
is correct).

[darcyclarke]

@wraithgar can we also write an E2E/smoke test that ensures this is sent to the registry properly when running a command w/ -w / -ws?

[isaacs]

As long as we still send a valid userAgent option in the flatOptions to all our modules, I don't think there's too much to discuss here. The only user-visible change is that process.env.npm_config_user_agent will no longer be the flattened version, correct?

[wraithgar]

Good point, the env one should ... probably be flattened?

[nlf]

As long as we still send a valid userAgent option in the flatOptions to all our modules, I don't think there's too much to discuss here. The only user-visible change is that process.env.npm_config_user_agent will no longer be the flattened version, correct?

i verified with node . run dumpconf that the environment variable is the flattened version, so we're good there

[nlf]

@wraithgar can we also write an E2E/smoke test that ensures this is sent to the registry properly when running a command w/ -w / -ws?

added a smoke test, it's a bit hacky but it gets the job done!

[nlf]

this looks very much correct. smoke test was added too so 👍