Skip to content

chore: add missing ldapLogin method in index.d.ts#205

Merged
aviadhahami merged 3 commits intonodevault:masterfrom
fonimus:patch-1
May 11, 2023
Merged

chore: add missing ldapLogin method in index.d.ts#205
aviadhahami merged 3 commits intonodevault:masterfrom
fonimus:patch-1

Conversation

@fonimus
Copy link
Contributor

@fonimus fonimus commented Nov 11, 2022

No description provided.

@aviadhahami
Copy link
Collaborator

Lgtm
I'm awaiting @kr1sp1n to grant me permissions to the CI so I can let them through

@kr1sp1n
Copy link
Collaborator

kr1sp1n commented Nov 14, 2022

Lgtm I'm awaiting @kr1sp1n to grant me permissions to the CI so I can let them through

It seems that travis-ci forces me to upgrade:
"We are unable to start your build at this time. You exceeded the number of users allowed for your plan. Please review your plan details and follow the steps to resolution."
I am not willing to do that.
@aviadhahami Maybe you find a free solution to run the automated tests in a CI pipeline. You should have enough rights to change the CI/CD-Provider. If not then please reach out to me.

@aviadhahami
Copy link
Collaborator

@kr1sp1n I can use GH actions with no problem, no need for old Travis.

I am able to push new GH actions config but I can't (???) remove the current CI :/ and that's why I pinged

Another part that's missing is how is the code being built and pushed the npm registry

I suggest we do a handover over zoom or equivalent and get it all sorted out and done with, wdyt?

@kr1sp1n
Copy link
Collaborator

kr1sp1n commented Nov 14, 2022

@aviadhahami To remove the current CI we need to move the .tavis.yml and remove it from travis. I can do this.
Regarding the building and publishing the lib: I think we should use github actions for this too.
I am open for a video-session via https://meet.jit.si/ Just give me a ping. I live in the Berlin/Germany timezone.

@aviadhahami
Copy link
Collaborator

let's set a call for tday (14/11/2022) @ 20:00 Berlin TZ, does this work?

@aviadhahami
Copy link
Collaborator

@kr1sp1n do u think we can set a meeting for this week? :) let's do the handover

@kr1sp1n
Copy link
Collaborator

kr1sp1n commented Nov 22, 2022

@aviadhahami I am sick at the moment and would love to have a meeting with you next week, ok? Have a great day!

@aviadhahami
Copy link
Collaborator

force-merging due to weird issue w/ codecov

@aviadhahami aviadhahami merged commit ab2857a into nodevault:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants