Skip to content

fix: remove support for non-real Blob objects#4937

Merged
mcollina merged 1 commit intonextfrom
fix/remove-non-real-blob-support
Mar 28, 2026
Merged

fix: remove support for non-real Blob objects#4937
mcollina merged 1 commit intonextfrom
fix/remove-non-real-blob-support

Conversation

@mcollina
Copy link
Copy Markdown
Member

Description

  • restrict isBlobLike() to real Blob instances
  • stop accepting Blob/File lookalikes based on Symbol.toStringTag
  • add regression coverage for fake blob-like values in util and request validation tests

Testing

  • npx borp -p "test/util.js"
  • node --test test/node-test/validations.js

@mcollina mcollina requested review from KhafraDev, Uzlopak and ronag March 28, 2026 08:33
@mcollina mcollina added the semver-major Features or fixes that will be included in the next semver major release label Mar 28, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (4b71486) to head (a23078f).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4937      +/-   ##
==========================================
- Coverage   92.94%   92.94%   -0.01%     
==========================================
  Files         111      111              
  Lines       35829    35815      -14     
==========================================
- Hits        33302    33287      -15     
- Misses       2527     2528       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina merged commit c971e46 into next Mar 28, 2026
54 of 56 checks passed
@mcollina mcollina deleted the fix/remove-non-real-blob-support branch March 28, 2026 13:24
This was referenced Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-major Features or fixes that will be included in the next semver major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants