fix(env-http-proxy-agent): assume http for schema-less proxy env vars#4860
Closed
nthbotast wants to merge 2 commits intonodejs:mainfrom
Closed
fix(env-http-proxy-agent): assume http for schema-less proxy env vars#4860nthbotast wants to merge 2 commits intonodejs:mainfrom
nthbotast wants to merge 2 commits intonodejs:mainfrom
Conversation
metcoder95
reviewed
Mar 4, 2026
| const HTTPS_PROXY = httpsProxy ?? process.env.https_proxy ?? process.env.HTTPS_PROXY | ||
| if (HTTPS_PROXY) { | ||
| this[kHttpsProxyAgent] = new ProxyAgent({ ...agentOpts, uri: HTTPS_PROXY }) | ||
| this[kHttpsProxyAgent] = new ProxyAgent({ ...agentOpts, uri: normalizeProxyURI(HTTPS_PROXY) }) |
Member
There was a problem hiding this comment.
What's the rationale of normalizing https to http?
unless tunneling, that can cause connect rejection from proxy.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
Let's do that. I can see a bit of ambiguity if I try to set a schema less origin |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
=======================================
Coverage 93.13% 93.14%
=======================================
Files 109 109
Lines 34243 34258 +15
=======================================
+ Hits 31893 31909 +16
+ Misses 2350 2349 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Mar 6, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http://scheme whenHTTP_PROXY/HTTPS_PROXYvalues are provided without a URL schemeEnvHttpProxyAgenttestsTesting
Closes #4736