Skip to content

copyedit profiling guide #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

copyedit profiling guide #446

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@Trott Trott commented Jan 5, 2016

No description provided.

@lpinca
Copy link
Member

lpinca commented Jan 6, 2016

LGTM.

@stevemao
Copy link
Contributor

stevemao commented Jan 6, 2016

Maybe leave a reference of where this is copied from?

fhemberger
fhemberger reviewed Jan 6, 2016
View reviewed changes
locale/en/docs/guides/simple-profiling.md
Copy link
Contributor

@fhemberger fhemberger Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superfluous space in command

@fhemberger
Copy link
Contributor

fhemberger commented Jan 6, 2016

@stevemao It's the exact same text as before (with adjusted wrapping) and new "isolate-0xnnnnnnnnnnnn-v8.log (where n is a digit)".

@stevemao
Copy link
Contributor

stevemao commented Jan 6, 2016

Oh from the commit message I thought it was copied from somewhere.

@Trott
Copy link
Member Author

Trott commented Jan 6, 2016

@stevemao I was using copyedit in this context: https://en.wikipedia.org/wiki/Copy_editing

I use that word a lot in my commit messages (when I'm fixing typos, punctuation, formatting, etc.) but if it's confusing to a lot of people, I can try to use a synonym instead.

@stevemao
Copy link
Contributor

stevemao commented Jan 6, 2016

@Trott It's Ok I guess. My English is very bad 😄

evanlucas
evanlucas reviewed Jan 7, 2016
View reviewed changes
locale/en/docs/guides/simple-profiling.md
Copy link
Contributor

@evanlucas evanlucas Jan 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, should we also mention the --prof-process flag now?

@matthewloring matthewloring mentioned this pull request Jan 8, 2016
Closed
@fhemberger
Copy link
Contributor

fhemberger commented Jan 9, 2016

Merged via 6a61f69, thanks!

@fhemberger fhemberger closed this Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott @lpinca @stevemao @fhemberger @evanlucas