src: avoid duplicate AtExit functions #8273
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
Member
|
LGTM |
addaleax
added
the
lib / src
Member
|
Btw, everytime I’m doing something inside |
Contributor
Author
|
@addaleax +1. However, atleast on my mac, the compiler doesn't like the function passed to atexit to be a lambda. I didn't try too hard though. |
Member
|
Yeah, it’s not that important anyway, was just a thought that occurred to me. |
Member
|
+1 LGTM if CI is green! |
Contributor
|
LGTM |
Member
|
LGTM, one less minor irritant. |
Member
|
CI was a bit too red: https://ci.nodejs.org/job/node-test-pull-request/3895/ |
node.cc had two functions with the name AtExit with entirely different purposes: * node::AtExit(): file static; used to register the atexit(3) handler for the Node process. * node::AtExit(void (*)(void*), void*): publicly exported symbol that addons can use to request callbacks upon exit. For code readability it is better to avoid the unintentional overload. PR-URL: nodejs#8273 Reviewed-By: addaleax - Anna Henningsen <[email protected]> Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]> Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
ofrobots
force-pushed
the
duplicate-AtExit
branch
from
0daa665 to
becbcc7
Compare
Contributor
Author
|
Thanks, the new CI was good, landed as becbcc7. |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
node.cc had two functions with the name AtExit with entirely different purposes: * node::AtExit(): file static; used to register the atexit(3) handler for the Node process. * node::AtExit(void (*)(void*), void*): publicly exported symbol that addons can use to request callbacks upon exit. For code readability it is better to avoid the unintentional overload. PR-URL: nodejs#8273 Reviewed-By: addaleax - Anna Henningsen <[email protected]> Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]> Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
node.cc had two functions with the name AtExit with entirely different purposes: * node::AtExit(): file static; used to register the atexit(3) handler for the Node process. * node::AtExit(void (*)(void*), void*): publicly exported symbol that addons can use to request callbacks upon exit. For code readability it is better to avoid the unintentional overload. PR-URL: #8273 Reviewed-By: addaleax - Anna Henningsen <[email protected]> Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]> Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Contributor
|
@ofrobots should this be backported? If so would you be able to submit a manual backport? |
Contributor
Author
|
No strong reason to backport this, specially if requires manual work :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
src
Description of change
node.cchad two functions with the nameAtExitwith entirely differentpurposes:
node::AtExit(): file static; used to register theatexit(3)handlerfor the Node process.
node::AtExit(void (*)(void*), void*): publicly exported symbol thataddons can use to request callbacks upon exit.
For code readability it is better to avoid the unintentional overload.
R=@addaleax, @bnoordhuis
EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/3835/