Conversation
|
Review requested:
|
sxa
left a comment
There was a problem hiding this comment.
As a possible follow-up, we could also mention the musl-based Linux arm64 binaries
+1 to this since we're now building it so it's as experimental as some of the others in the table.
Commenting as opposed to approving/rejecting as I'd like to see the arm64 change in but I won't block if you want to do it separately :-)
|
Is https://github.com/nodejs/unofficial-builds/blob/main/recipes/musl/Dockerfile used for every active release lines (v20.x, v22.x, v24.x, v25.x)? |
I believe so. Given that commit nodejs/unofficial-builds@d8eaee5 landed on May 6, 2024, the binaries built with Alpine 3.19 likely correspond to the version range: |
|
This part of the doc doesn't refer to compatibility of the unofficial binaries -- it is supposed to indicate compatibility in general for that platform (e.g. building from source yourself). They are most likely best guesses because I don't think anyone has tried to extensively test Node.js against kernel versions. The requirements to run the official binaries are in the "Official binary platforms and toolchains" section. There is no section for unofficial builds, and I would block any addition/mention of unofficial builds to BUILDING.md (as unofficial builds are unofficial). |
d100bfe to
46ce09f
Compare
These binaries are build with Alpine 3.19.
These binaries are cross-compiled with `x64-gcc-12.3.0-glibc-2.28` from: https://github.com/rvagg/rpi-newer-crosstools.
These binaries are build with Ubuntu 24.04.
46ce09f to
801df37
Compare
BUILDING.md
Outdated
| [^5]: Older kernel or libc versions may work. The minimum versions listed here | ||
| correspond to the binaries provided by the | ||
| [unofficial-builds project](https://github.com/nodejs/unofficial-builds). |
There was a problem hiding this comment.
I'm -1 on mentioning unofficial-builds in this document. We do not want people relying on them.
There was a problem hiding this comment.
Understood. The mention has been removed.
801df37 to
d56e41c
Compare
d56e41c to
cb86db8
Compare
See the individual commits for more details.