[v24.x backport] src: use CP_UTF8 for wide file names on win32 #60630
+86
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Member
Author
|
cc @nodejs/lts @addaleax |
Member
Author
|
@aduh95 ah, I didn't know that! well, at least we have the PR open now so that we don't have to do much more work when the commit matures. |
aduh95
force-pushed
the
v24.x-staging
branch
from
de223ed to
daaaf04
Compare
`src/node_modules.cc` needs to be consistent with `src/node_file.cc` in how it translates the utf8 strings to `std::wstring` otherwise we might end up in situation where we can read the source code of imported package from disk, but fail to recognize that it is an ESM (or CJS) and cause runtime errors. This type of error is possible on Windows when the path contains unicode characters and "Language for non-Unicode programs" is set to "Chinese (Traditional, Taiwan)". See: nodejs#58768 PR-URL: nodejs#60575 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
targos
force-pushed
the
backport-60575-to-24
branch
from
6620c44 to
b986338
Compare
Member
|
Rebased. |
Member
|
Backport is no longer needed. I cherry-picked the commit cleanly to v24.x-staging: d92ec21 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/node_modules.ccneeds to be consistent withsrc/node_file.ccin how it translates the utf8 strings tostd::wstringotherwise we might end up in situation where we can read the source code of imported package from disk, but fail to recognize that it is an ESM (or CJS) and cause runtime errors. This type of error is possible on Windows when the path contains unicode characters and "Language for non-Unicode programs" is set to "Chinese (Traditional, Taiwan)".See: #58768
PR-URL: #60575
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Stefan Stojanovic [email protected]
Reviewed-By: Juan José Arboleda [email protected]
Reviewed-By: Joyee Cheung [email protected]
Reviewed-By: Rafael Gonzaga [email protected]