Skip to content

Conversation

@SeokhunEom
Copy link
Contributor

Corrects the misspelling of "privateSynbol" to "privateSymbol".

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (535efea) to head (17d993a).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/quic/stats.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60155      +/-   ##
==========================================
- Coverage   88.55%   88.53%   -0.03%     
==========================================
  Files         704      704              
  Lines      208081   208081              
  Branches    40011    40010       -1     
==========================================
- Hits       184270   184220      -50     
- Misses      15826    15867      +41     
- Partials     7985     7994       +9     
Files with missing lines Coverage Δ
lib/internal/quic/stats.js 95.31% <66.66%> (ø)

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hritikk999
Copy link

1 Failed, 20 successful checks

@nodejs-github-bot

This comment was marked as outdated.

Corrects the misspelling of "privateSynbol" to "privateSymbol".
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2025
@nodejs-github-bot
Copy link
Collaborator

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2025
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit 4daeec1 into nodejs:main Oct 10, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4daeec1

aduh95 pushed a commit that referenced this pull request Oct 31, 2025
Corrects the misspelling of "privateSynbol" to "privateSymbol".

PR-URL: #60155
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
Corrects the misspelling of "privateSynbol" to "privateSymbol".

PR-URL: #60155
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants