Skip to content

Conversation

@GoldFish2500
Copy link

Check return value of EVP_EncryptInit_ex and EVP_DecryptInit_ex in SecureContext::TicketKeyCallback().

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels May 19, 2025
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (b395420) to head (9c656d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/crypto/crypto_context.cc 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58393      +/-   ##
==========================================
- Coverage   90.22%   90.22%   -0.01%     
==========================================
  Files         633      633              
  Lines      187027   187029       +2     
  Branches    36720    36719       -1     
==========================================
- Hits       168746   168744       -2     
+ Misses      11083    11071      -12     
- Partials     7198     7214      +16     
Files with missing lines Coverage Δ
src/crypto/crypto_context.cc 68.82% <0.00%> (-0.34%) ⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GoldFish2500 GoldFish2500 force-pushed the patch-11-check-encrypt-decrypt-return-value branch from c9f9731 to 9c656d8 Compare May 19, 2025 17:56
@joyeecheung
Copy link
Member

joyeecheung commented Jun 9, 2025

Linters and commit message tests are failing. Can you check the GitHub actions and fix according to the messages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants