Skip to content

Conversation

@Ceres6
Copy link
Contributor

@Ceres6 Ceres6 commented Oct 30, 2024

change assertions on test-fs-watch-recursive-add-* tests to only take into account change events that match the file

Fixes #55592

change assertions on test-fs-watch-recursive-add-* tests to only take
into account change events that match the file
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 30, 2024
@Ceres6
Copy link
Contributor Author

Ceres6 commented Oct 30, 2024

cc @pmarchini

@avivkeller avivkeller added the watch-mode Issues and PRs related to watch mode label Oct 30, 2024
@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (6dea41d) to head (2a5af5f).
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55605      +/-   ##
==========================================
- Coverage   88.43%   87.94%   -0.50%     
==========================================
  Files         654      654              
  Lines      187699   187751      +52     
  Branches    36125    35833     -292     
==========================================
- Hits       165995   165110     -885     
- Misses      14948    15829     +881     
- Partials     6756     6812      +56     

see 93 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2024
@nodejs-github-bot
Copy link
Collaborator

@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 30, 2024
Copy link
Member

@pmarchini pmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @Ceres6 🚀

Since we're already working on this part, I’d follow @lpinca's suggestion and remove

if (common.isMacOS) {
// On macOS delay watcher start to avoid leaking previous events.
// Refs: https://github.com/libuv/libuv/pull/4503
setTimeout(doWatch, common.platformTimeout(100));
} else {
doWatch();
}

I'd also review the other timeouts in the tests modified by this PR, as they might have been added to address this issue 🚀

@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 changed the title fs: ignore unrelated events in watch tests test: ignore unrelated events in FS watch tests Nov 5, 2024
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 merged commit 42f4659 into nodejs:main Nov 6, 2024
25 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Nov 6, 2024

Landed in 42f4659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. watch-mode Issues and PRs related to watch mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test-fs-watch-recursive-add-* tests fail intermittently on macOS

8 participants