test_runner: fix test counting #47699
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
MoLow
commented
Apr 24, 2023
| # Warning: Test "callback async throw after done" generated asynchronous activity after the test ended. This activity created the error "Error: thrown from callback async throw after done" and would have caused the test to fail, but instead triggered an uncaughtException event. | ||
| 1..66 | ||
| # tests 80 | ||
| # Subtest: last test |
Member
Author
There was a problem hiding this comment.
on main, this diff would have been:
diff --git a/test/fixtures/test-runner/output/output_cli.snapshot b/test/fixtures/test-runner/output/output_cli.snapshot
index 1d2ea1db9f..a4d54b29cd 100644
--- a/test/fixtures/test-runner/output/output_cli.snapshot
+++ b/test/fixtures/test-runner/output/output_cli.snapshot
@@ -675,7 +675,7 @@ not ok 66 - invalid subtest fail
# Subtest: last test
-ok 2 - last test
+ok 67 - last test
---
duration_ms: *
..
cjihrig
approved these changes
Apr 24, 2023
MoLow
force-pushed
the
fix-test-runner-count
branch
2 times, most recently
from
dd2cd39 to
c07254f
Compare
MoLow
force-pushed
the
fix-test-runner-count
branch
from
c07254f to
8129d86
Compare
Member
Author
|
superseded by #47675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #47696
this also improves the test for #46577