src: allow embedder control of code generation policy #46368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
the
embedding
nodejs-github-bot
added
c++
Member
|
@nodejs/cpp-reviewers |
addaleax
added
the
semver-major
addaleax
approved these changes
Jan 26, 2023
RafaelGSS
approved these changes
Jan 26, 2023
codebytere
force-pushed
the
allow-embedder-codegen-control
branch
from
8c13d11 to
fb174f5
Compare
addaleax
approved these changes
Jan 30, 2023
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
codebytere
force-pushed
the
allow-embedder-codegen-control
branch
from
fb174f5 to
78e7268
Compare
github-actions
bot
removed
the
request-ci
Collaborator
codebytere
added
semver-minor
codebytere
force-pushed
the
allow-embedder-codegen-control
branch
from
78e7268 to
885fce8
Compare
addaleax
approved these changes
Jan 31, 2023
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
(just re-approving so that CQ doesn’t complain when merging this)
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
codebytere
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3aaeb30 |
22 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs electron/electron#36567.
This PR allows for embedder control over whether or not code generation from strings is allowed. This is particularly important for embedders that combine Node and Blink, as Electron does, because Blink must be able to make Content Security Policy-based decisions. Without the ability to control this, we experience crashes.
This allows Electron to remove a patch we currently float to enable this.