Skip to content

Conversation

@willin
Copy link

@willin willin commented Sep 15, 2021

add ignored paths. which is from macos and asan

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 15, 2021
@willin willin changed the title ci: optimize linux test workflow build: optimize linux test workflow Sep 15, 2021
on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
paths-ignore:
Copy link
Contributor

@Mesteery Mesteery Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to run at least one build for doc changes -- at least one test checks for consistency between documentation and run time (hence needing a built node binary) behaviour:

#39871 (comment)

Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending the PR. As the other comment says, I don't think we should disable the test-linux workflow as we still want to have those tests run at least once, and it's the build job that takes the least time to complete.

@bjohansebas bjohansebas added the stalled Issues and PRs that are stalled. label Nov 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@github-actions
Copy link
Contributor

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

@github-actions github-actions bot closed this Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project. stalled Issues and PRs that are stalled.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants