Skip to content

quic misc fix #33975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengjiawen wants to merge 2 commits into from
Closed

quic misc fix #33975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f8fe4c
quic: fix typo in comments
gengjiawen Jun 19, 2020
b609c5e
quic: fix clang-tidy performance-faster-string-find issue
gengjiawen Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/quic/node_quic_crypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ bool CheckCertNames(
return false;
}

if (name_parts[0].find("*") == std::string::npos ||
if (name_parts[0].find('*') == std::string::npos ||
name_parts[0].find("xn--") != std::string::npos) {
return host_parts[0] == name_parts[0];
}
Expand Down
2 changes: 1 addition & 1 deletion src/quic/node_quic_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class StatsBase {
// A StatsBase instance may have one of three histogram
// instances. One that records rate of data flow, one
// that records size of data chunk, and one that records
// rate of data ackwowledgement. These may be used in
// rate of data acknowledgement. These may be used in
// slightly different ways of different StatsBase
// instances or may be turned off entirely.
enum HistogramOptions {
Expand Down