test: mark test-dgram-multicast-ssmv6-multi-process flaky#33498
Closed
AshCripps wants to merge 1 commit intonodejs:masterfrom
Closed
test: mark test-dgram-multicast-ssmv6-multi-process flaky#33498AshCripps wants to merge 1 commit intonodejs:masterfrom
AshCripps wants to merge 1 commit intonodejs:masterfrom
Conversation
refs: nodejs#32946 Mark this test as flaky on linux Ive used sequential.status as a template for this file
AshCripps
force-pushed
the
mark-flaky-dgram-test
branch
from
0a62fca to
eaef98e
Compare
Collaborator
richardlau
approved these changes
May 21, 2020
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Changes LGTM. Since this is in internet this must be failing during the daily runs? In which case you may need to check how that job is treating flaky tests (i.e. is --flaky-tests= being set for the test harness).
Contributor
|
the daily triggers this through https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/configure, and it looks good
|
Contributor
|
I propose fast-tracking if CI is green for the PR. |
sam-github
added
the
fast-track
lpinca
approved these changes
May 22, 2020
Collaborator
Contributor
|
Landed in e14786f |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: #32946
Mark this test as flaky on linux as its been failing
test-commit-custom-suites-freestylefor a whileIve used sequential.status as a template for this file.