Remove TODO for moving net.isIP into dns #286
Conversation
|
was this discussed somewhere? the api is not really specific to name resolution, and it seems like a pretty serious compat-break |
|
It simply had a TODO comment that it needed to be moved to dns. I do understand the concern though. |
|
it's not crystal clear to me what @ry's thought process was when saying it belonged in |
|
That's a good idea |
|
before going too crazy, just remember that if people started using both, there'd be two sets of duplicate apis to worry about, not sure anyone wants that =) anyway, happy hacking~ |
|
@evanlucas IMO, there's much less churn if you simply remove the comment. Like @caitp said, isIP() is not really DNS-specific. The comment is arguably wrong. |
|
That works for me. Thanks! |
It is not really DNS-specific so keeping it in net makes more sense.
evanlucas
force-pushed
the
isIP-into-dns
branch
from
4890d10 to
e20290b
Compare
evanlucas
changed the title
|
Ok, I went ahead and changed it to only remove the comment. |
It is not really DNS-specific so keeping it in net makes more sense. PR-URL: #286 Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks Evan, landed in d51efd0! |
3 participants
Moves isIP and related functions to dns.
This change does affect how the dns module is loaded in net. It is no longer loaded lazily.
This PR also updates the docs for the change.
EDIT: Updated to simply remove the comment.