timers: fix refreshed timers exiting too early #26672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a timer is refreshed in its callback, we should not decrease `refCount` to prevent exiting event loop ahead of time. Fixes: nodejs#26642
nodejs-github-bot
added
the
timers
Contributor
Author
Member
|
@nodejs/timers |
richardlau
approved these changes
Mar 15, 2019
BridgeAR
approved these changes
Mar 15, 2019
BridgeAR
added
the
author ready
Contributor
|
I feel like there should be a better way to do this using existing properties but i’ll Need to check exactly when I am at my computer. |
apapirovski
suggested changes
Mar 17, 2019
Contributor
There was a problem hiding this comment.
This is possible without a new property but also the current implementation is broken because the timer ends up "refed" in a way that cannot actually be unrefed later (note that timer[kRefed] is still set to null). The destroy hooks will also fire even though they shouldn't.
Contributor
Author
|
Closed due to #26721 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a timer is refreshed in its callback, we should not decrease
refCountto prevent exiting event loop ahead of time.Fixes: #26642
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes