Skip to content

src: add override to ThreadPool methods in zlib #20769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 2 commits into from
Closed

src: add override to ThreadPool methods in zlib #20769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98b4faa
src: add override to ThreadPool methods in zlib
danbev May 16, 2018
f665e8b
squash: remove extra white line
danbev May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/node_zlib.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class ZCtx : public AsyncWrap, public ThreadPoolWork {
// This function may be called multiple times on the uv_work pool
// for a single write() call, until all of the input bytes have
// been consumed.
void DoThreadPoolWork() {
void DoThreadPoolWork() override {
const Bytef* next_expected_header_byte = nullptr;

// If the avail_out is left at 0, then it means that it ran out
Expand Down Expand Up @@ -353,7 +353,7 @@ class ZCtx : public AsyncWrap, public ThreadPoolWork {


// v8 land!
void AfterThreadPoolWork(int status) {
void AfterThreadPoolWork(int status) override {
write_in_progress_ = false;

if (status == UV_ECANCELED) {
Expand Down