Skip to content

Conversation

@edsadr
Copy link
Member

@edsadr edsadr commented Jan 25, 2017

use better RegExp to validate the errors in assert.throws

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 25, 2017
@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. and removed dont-land-on-v7.x labels Jan 25, 2017
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: err is unused. Remove it?

@Trott
Copy link
Member

Trott commented Jan 25, 2017

Nit: While we're in here refactoring, maybe change the rocket function on lines 117-119 from this:

(err) => {
   return err.code === 'ENOENT' && err.path === doesNotExist;
 }

...to this?:

(err) => (err.code === 'ENOENT' && err.path === doesNotExist)

Both styles show up in our code base, but the latter (no unnecessary braces + return) is far more common and I'd like to see things inch towards a common style that can then be enforced by a lint rule.

 use better RegExp to validate the errors in assert.throws
@edsadr
Copy link
Member Author

edsadr commented Jan 31, 2017

@Trott , did the Nits... sorry it took a little bit... had a hard week

@italoacasas
Copy link

@edsadr
Copy link
Member Author

edsadr commented Jan 31, 2017

Closing this one in favor of #11087

@edsadr edsadr closed this Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants