Aduh95 #17
Draft
Aduh95 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@aduh95 ... Just wanted to get a sense of what this PR is working towards. Want to have context for a review. This is used by workers and bun also so need to know if there are significant changes that would require attention there also |
Author
|
The end goal would be to be able to build it as a shared lib and use it in node (in the test-shared workflow), and make node depend on this repo. The current state is that I'm able to build it as a shared lib, but static build seems broken from the looks of CI, I haven't investigated further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code is maintained in two different repos (nodejs/node and nodejs/ncrypto) which are slightly diverging, and do not support building as a shared lib.
The end goal would be to be able to build it as a shared lib and use it in nodejs/node (in the test-shared workflow), and make node depend on this repo (i.e. to update nodejs/node, changes would need to first land here).
FWIW I didn't intend to open this, I was planning in sending in separate PRs, but I opened it by accident so I figure I might as well keep it as draft until I get a green CI so I can start sending dedicated PRs.