Skip to content

use Buffer.from('text') rather than new Buffer('text') when available #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkrufky merged 4 commits into from
May 26, 2018
Merged

use Buffer.from('text') rather than new Buffer('text') when available #778

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4632e21
strings-test.js: use Buffer.from('text') rather than new Buffer('text')
mkrufky May 25, 2018
50f2a20
strings-test.js: check that Buffer.from is available else new Buffer()
mkrufky May 25, 2018
a7198b0
test/js/strings-test.js: DRY / cleanup
mkrufky May 25, 2018
581aeb6
check Buffer.alloc rather than Buffer.from because we don't want the …
mkrufky May 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion test/js/strings-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,15 @@ test('FromV8String', function (t) {
t.equal(a('an utf8 strïng'), 'an utf8 strïng');
t.equal(b('an utf8 strïng'), 'an utf8 strïng');

t.equal(bindings.encodeHex(), new Buffer('hello').toString('hex'));
var buf;

/* we check Buffer.alloc rather than Buffer.from because
* we don't want the base class Uint8Array.from */
if (typeof(Buffer.alloc) === "function") {
buf = Buffer.from('hello');
} else {
buf = new Buffer('hello');
}
t.equal(bindings.encodeHex(), buf.toString('hex'));
t.equal(bindings.encodeUCS2(), 'hello');
});