Skip to content

Fix crash when WeMo devices are powered off#794

Merged
hardillb merged 11 commits intonode-red:masterfrom
hardillb:master
Apr 10, 2021
Merged

Fix crash when WeMo devices are powered off#794
hardillb merged 11 commits intonode-red:masterfrom
hardillb:master

Conversation

@hardillb
Copy link
Copy Markdown
Member

@hardillb hardillb commented Apr 8, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Catch errors when wemo device are powered off

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

closes #791

Includes:
 - New lookup node to check state of a device
 - Fix dimming control for lights
 - Fix light group control
 - Set the node label to match the device name
 - The event now includes the text description of the light capability
This is to catch errors when device is offline
Will look at making it all http.request later
Failed subscriptions will try agian in 1 min
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 49.111% when pulling 123e7f6 on hardillb:master into 040bf24 on node-red:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 49.111% when pulling 123e7f6 on hardillb:master into 040bf24 on node-red:master.

@hardillb hardillb marked this pull request as ready for review April 9, 2021 11:49
@hardillb hardillb merged commit 874708d into node-red:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node-red-node-wemo uncaught exception on EHOSTUNREACH

2 participants