Open
Conversation
Member
Author
|
已跑过《广韵》的所有小韵验证 |
ayaka14732
reviewed
Jul 10, 2021
Member
ayaka14732
left a comment
ayaka14732
left a comment
There was a problem hiding this comment.
Can simplify by using IntEnum
Using IntEnum now Co-authored-by: Ayaka Mikazuki <ayaka@tuta.io>
syimyuzya
approved these changes
Jul 10, 2021
ayaka14732
reviewed
Jul 10, 2021
Member
ayaka14732
left a comment
ayaka14732
left a comment
There was a problem hiding this comment.
- 可以在註釋中解釋一下「無效」、「強非法」、「弱非法」有什麼區別
- 可以在註釋中解釋一下為什麼不合法
commit 64fd85c Author: Ayaka Mikazuki <ayaka@mail.shn.hk> Date: Sat Jul 10 17:07:19 2021 +0800 Fix bug commit e46cb11 Author: Ayaka Mikazuki <ayaka@mail.shn.hk> Date: Sat Jul 10 17:00:06 2021 +0800 Fix bug commit 935450d Author: Ayaka Mikazuki <ayaka@mail.shn.hk> Date: Sat Jul 10 16:57:32 2021 +0800 Fix bug commit 8bf6baa Author: Ayaka Mikazuki <ayaka@mail.shn.hk> Date: Sat Jul 10 16:56:20 2021 +0800 Support Python 3.10 and drop support of Python 3.6
Member
|
最低 Python 版本改成 3.7 了，現在 typing 應該沒問題了 |
Member
Author
|
@ayaka14732 注释加上啦 |
Member
Author
|
我累死了 |
syimyuzya
approved these changes
Jul 10, 2021
ayaka14732
requested changes
Jul 11, 2021
src/QieyunEncoder/音韻地位.py
Outdated
Comment on lines
624
to
632
Member
There was a problem hiding this comment.
Move to the documentation of class 合法性
Member
There was a problem hiding this comment.
Are we going to export 合法性等級, without actual usage in the API? (as 音韻地位.合法性() only returns its str form)
if not, how do we include it in the docs?
My suggestion: Would it be better if we add a link in the doc of 合法性等級 mentioning 音韻地位.合法性() instead, showing that it is an implementation detail of the public method?
Co-authored-by: Ayaka Mikazuki <ayaka@tuta.io>
Co-authored-by: Ayaka Mikazuki <ayaka@tuta.io>
syimyuzya
requested changes
Jul 11, 2021
列表前空一行（否則文檔生成工具 pdoc3 不認識這是列表） Co-authored-by: Sekai Zhou <syimyuzya@gmail.com>
syimyuzya
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.