Skip to content

Add "to_dict" to skipped helper methods in test #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaburagisec merged 1 commit into from
Jan 13, 2026
Merged

Add "to_dict" to skipped helper methods in test #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/services/base_service_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def test_no_duplicate_methods(self):
continue

# Skip helper methods
if method_name in ["type", "desc", "operations"]:
if method_name in ["type", "desc", "operations", "to_dict"]:
continue

method_names.append(method_name)
Expand Down Expand Up @@ -388,7 +388,7 @@ def test_operator_call_usage(self):
implemented_methods = self.get_implemented_methods()

# Skip helper methods that don't call operator.call()
helper_methods = ["type", "desc", "operations"]
helper_methods = ["type", "desc", "operations", "to_dict"]

errors = []

Expand Down Expand Up @@ -447,7 +447,7 @@ def test_no_extra_methods(self):
implemented_methods = self.get_implemented_methods()

# Allowed helper methods that are not ONVIF operations
allowed_helper_methods = ["type", "desc", "operations"]
allowed_helper_methods = ["type", "desc", "operations", "to_dict"]

extra_methods = []
for method_name in implemented_methods.keys():
Expand Down Expand Up @@ -482,7 +482,7 @@ def test_parameter_forwarding_for_all_methods(self):
implemented_methods = self.get_implemented_methods()

# Skip helper methods that don't call operator.call()
helper_methods = ["type", "desc", "operations"]
helper_methods = ["type", "desc", "operations", "to_dict"]

errors = []

Expand Down