Skip to content

Add subtool cellranger aggregate#10656

Open
alenaboos wants to merge 21 commits intonf-core:masterfrom
Bioinformatics-Munich:cellranger_aggr
Open

Add subtool cellranger aggregate#10656
alenaboos wants to merge 21 commits intonf-core:masterfrom
Bioinformatics-Munich:cellranger_aggr

Conversation

@alenaboos
Copy link
Copy Markdown

@alenaboos alenaboos commented Mar 12, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics >Not possible: module uses a Python template; Nextflow eval() output is Bash-only. Same limitation as cellranger/count.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements. > Not available for conda
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@alenaboos alenaboos enabled auto-merge March 12, 2026 13:44
@alenaboos
Copy link
Copy Markdown
Author

The conda tests are failing, but cellranger does not exist for conda. Therefore, I included an error message when running the module with the conda profile similar to the cellranger count module.

@alenaboos alenaboos requested review from a team as code owners March 13, 2026 09:17
Copy link
Copy Markdown
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a python wrapper to run a command line tool? Because if so, you should just run directly in the main.nf without involving python.

@alenaboos
Copy link
Copy Markdown
Author

Yes, I did it similar to the cellranger count module, but I will add the command to the main.nf. The command requires to have the input files as a csv table. Should this be another process in the actual pipeline or should I also add the csv generation to this module?

@SPPearce
Copy link
Copy Markdown
Contributor

That depends on how complex the csv generation is, but if it is just a list then should be able to be done within this module

@alenaboos
Copy link
Copy Markdown
Author

I included the csv file generation into the module and also added the command directly instead of providing it as a py script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants