Add subtool cellranger aggregate#10656
Conversation
…ns and update maintainers list
…data descriptions in YAML files
|
The conda tests are failing, but cellranger does not exist for conda. Therefore, I included an error message when running the module with the conda profile similar to the cellranger count module. |
SPPearce
left a comment
There was a problem hiding this comment.
Is this just a python wrapper to run a command line tool? Because if so, you should just run directly in the main.nf without involving python.
|
Yes, I did it similar to the cellranger count module, but I will add the command to the main.nf. The command requires to have the input files as a csv table. Should this be another process in the actual pipeline or should I also add the csv generation to this module? |
|
That depends on how complex the csv generation is, but if it is just a list then should be able to be done within this module |
|
I included the csv file generation into the module and also added the command directly instead of providing it as a py script. |
PR checklist
topic: versions- See version_topics >Not possible: module uses a Python template; Nextfloweval()output is Bash-only. Same limitation ascellranger/count.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda