Skip to content

Fix how replicates are set for downstream analysis#420

Merged
JoseEspinosa merged 4 commits intonf-core:devfrom
JoseEspinosa:updates
Oct 7, 2024
Merged

Fix how replicates are set for downstream analysis#420
JoseEspinosa merged 4 commits intonf-core:devfrom
JoseEspinosa:updates

Conversation

@JoseEspinosa
Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a950571

+| ✅ 222 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   5 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.1.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-10-07 12:35:24

@JoseEspinosa JoseEspinosa changed the title Fix how replicates are set for downstream analysisUpdates Fix how replicates are set for downstream analysis Oct 7, 2024
Copy link
Copy Markdown
Contributor

@bjlang bjlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoseEspinosa JoseEspinosa merged commit 11ded3d into nf-core:dev Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants