Fix URL escaping of shared files#509
Merged
skjnldsv merged 1 commit intonextcloud:masterfrom Nov 7, 2020
Merged
Conversation
Member
|
Yeah, that whole thing was confusing. There was some attempts that broke other stuff So all of this works on various browsers and files with |
skjnldsv
force-pushed
the
fix-shares-preview
branch
from
bef28f1 to
75d1f91
Compare
skjnldsv
added
4. to release
skjnldsv
approved these changes
Nov 7, 2020
Member
|
/compile amend / |
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
fix-shares-preview
branch
from
75d1f91 to
47a7d33
Compare
Member
|
/backport to stable20 |
backportbot-nextcloud
bot
added
the
backport-request
Member
|
/backport to stable19 |
This was referenced Nov 7, 2020
Member
|
/backport to stable18 |
|
The backport to stable18 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes nextcloud/server#20671 which was incorrectly flagged (at least I believe so) as duplicate of #415 .
I'm unable to reproduce #415 on JPG files, and I doubt these two are the same issues.