fix(image-editor): prevent double discard changes confirmation#2814
fix(image-editor): prevent double discard changes confirmation#2814
Conversation
szaimen
left a comment
There was a problem hiding this comment.
Tested and seems to work. However did not review the code
|
/backport to stable31 |
|
/backport to stable30 |
|
Not too fond of keeping the one from the editor library, as it looks weird. |
There's no config or straight forward way to do it , I can create a PR upstream tho |
|
@hamza221 thanks, but the lib maintainers are not super reactive. |
f0f12dd to
4497eb2
Compare
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
4497eb2 to
c1fcd3c
Compare
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/2814/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c1fcd3cb
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2814/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/2814/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c1fcd3cb
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2814/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Reproduction:
Actual behaviour :
Receive 2 consecutive confirmation modal from the editor and then from Nextcloud
Expected behavior:
Confirm once