Fix sidebar opening for different dav root and non-dav files#1416
Merged
Fix sidebar opening for different dav root and non-dav files#1416
Conversation
skjnldsv
added
bug
skjnldsv
force-pushed
the
fix/sidebar-open
branch
from
228a537 to
9bf2fb7
Compare
Member
Author
|
/backport to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
skjnldsv
force-pushed
the
fix/sidebar-open
branch
from
9bf2fb7 to
08abb24
Compare
szaimen
requested review from
a team,
PVince81,
artonge and
szaimen
and removed request for
a team
skjnldsv
added
2. developing
skjnldsv
force-pushed
the
fix/sidebar-open
branch
from
08abb24 to
c97abea
Compare
skjnldsv
added
3. to review
Member
Author
|
Ready for reviews |
PVince81
approved these changes
Oct 24, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 code looks fine, an extra safety would be nice, see comment
artonge
reviewed
Oct 24, 2022
skjnldsv
force-pushed
the
fix/sidebar-open
branch
from
c97abea to
f95f066
Compare
skjnldsv
added
4. to release
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/sidebar-open
branch
from
f95f066 to
0db4bbd
Compare
artonge
approved these changes
Oct 24, 2022
1 task
backportbot-nextcloud
bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/photos#1289
Fix nextcloud/photos#1360