Production/cafevdb/stable27 #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
… to avoid duplicates.
In particular when using the catch-all group ("Default Group" setting)
the queries which count and select users from the User-Group table need
the "DISTINCT" option: the catch-all group is replaced by a '%'
wild-card in the query. As users may belong by design to more than one
group counting and selecting users comes out wrong. Even worse: the many
duplicates interfere with the paging logic of the user admin-settings.
Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
…rom an array representation to the User-object. Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
The code used union selects; left joins at least are easier to read. In some places it was also not so clear that the WHERE part for the disabled column really worked. The query FIND_GROUP_USERS also needs to take the disabled column in to account. Signed-off-by: Claus-Justus Heine <[email protected]>
… username column. Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
Signed-off-by: Claus-Justus Heine <[email protected]>
rotdrop
force-pushed
the
production/cafevdb/stable27
branch
from
c238516 to
2d83a88
Compare
Contributor
Author
Signed-off-by: Claus-Justus Heine <[email protected]>
rotdrop
force-pushed
the
production/cafevdb/stable27
branch
from
22c01bb to
3cc3bf2
Compare
|
Thanks for doing this. I'm not a developer on here, but I wanted to confirm that I'm running Nextcloud 27.1.1 with php8.2 on FreeBSD 13.2-RELEASE and I just installed the version referenced by this PR and it is working on my system. I mean, I know that's not much: it's just one dude saying "works on my machine". But hey, it works on my machine. Thanks for making the PR available! |
|
Any news on this PR? |
|
@rotdrop many thanks for this, you're a life saver ! And finally this got merged, but we still need to have a new version tagged... @mlojewski-me ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of updates
This PR supersedes my other PRs.